-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Table
Expand Collapse All Documentation
#2748
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/public/assets/components/table/advanced-table/expandable-rows-collapsed-state.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Lee White <lee.white@hashicorp.com>
…es/guidelines.md Co-authored-by: Lee White <lee.white@hashicorp.com>
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/public/assets/components/table/advanced-table/expandable-rows-collapsed-state.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heading structure needs to be updated. I also suggest moving this under the "Headers" section, as the button is only available within the Table Headers.
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions but otherwise looks good.
Co-authored-by: Heather Larsen <hlarsen@hashicorp.com> Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
…es/guidelines.md Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
…es/guidelines.md Co-authored-by: Lee White <lee.white@hashicorp.com>
##### Expanded state | ||
|
||
 | ||
<Doc::ImageCaption @text="Once all rows are expanded, the Collapse All button is displayed."/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Doc::ImageCaption @text="Once all rows are expanded, the Collapse All button is displayed."/> | |
<Doc::ImageCaption @text="Once all rows are expanded, the “Collapse All” button is displayed."/> |
##### Mixed state | ||
|
||
 | ||
<Doc::ImageCaption @text="If some rows are expanded and others are collapsed, the Expand All button will persist until all rows are expanded."/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Doc::ImageCaption @text="If some rows are expanded and others are collapsed, the Expand All button will persist until all rows are expanded."/> | |
<Doc::ImageCaption @text="If some rows are expanded and others are collapsed, the “Expand All” button will persist until all rows are expanded."/> |
📌 Summary
If merged, this PR will add documentation for the Expand/Collapse All button to the Advanced Table documentation. It covers the button's purpose, interactions, and behavior when expanding or collapsing rows, including nested ones.
👀 Showcase here ----> https://hds-website-git-advanced-table-expand-collapse-ea1c2e-hashicorp.vercel.app/components/table/advanced-table#expandcollapse-all-button
🔗 External links
Jira ticket: HDS-4543