Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Table Expand Collapse All Documentation #2748

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

andgen404
Copy link
Contributor

@andgen404 andgen404 commented Mar 6, 2025

📌 Summary

If merged, this PR will add documentation for the Expand/Collapse All button to the Advanced Table documentation. It covers the button's purpose, interactions, and behavior when expanding or collapsing rows, including nested ones.

👀 Showcase here ----> https://hds-website-git-advanced-table-expand-collapse-ea1c2e-hashicorp.vercel.app/components/table/advanced-table#expandcollapse-all-button

🔗 External links

Jira ticket: HDS-4543

Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Mar 28, 2025 3:54pm
hds-website ✅ Ready (Inspect) Visit Preview Mar 28, 2025 3:54pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Mar 6, 2025
andgen404 and others added 2 commits March 26, 2025 07:34
Co-authored-by: Lee White <lee.white@hashicorp.com>
…es/guidelines.md

Co-authored-by: Lee White <lee.white@hashicorp.com>
shleewhite
shleewhite previously approved these changes Mar 26, 2025
Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading structure needs to be updated. I also suggest moving this under the "Headers" section, as the button is only available within the Table Headers.

Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions but otherwise looks good.

Co-authored-by: Heather Larsen <hlarsen@hashicorp.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
andgen404 and others added 2 commits March 28, 2025 08:48
…es/guidelines.md

Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
…es/guidelines.md

Co-authored-by: Lee White <lee.white@hashicorp.com>
##### Expanded state

![](/assets/components/table/advanced-table/expandable-rows-collapse-state.png)
<Doc::ImageCaption @text="Once all rows are expanded, the Collapse All button is displayed."/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Doc::ImageCaption @text="Once all rows are expanded, the Collapse All button is displayed."/>
<Doc::ImageCaption @text="Once all rows are expanded, the Collapse All button is displayed."/>

##### Mixed state

![](/assets/components/table/advanced-table/expandable-rows-mixed-state.png)
<Doc::ImageCaption @text="If some rows are expanded and others are collapsed, the Expand All button will persist until all rows are expanded."/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Doc::ImageCaption @text="If some rows are expanded and others are collapsed, the Expand All button will persist until all rows are expanded."/>
<Doc::ImageCaption @text="If some rows are expanded and others are collapsed, the Expand All button will persist until all rows are expanded."/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants